Skip to content

London | 26-ITP-Sep | Shirin Panahian | Sprint 2 | Practice TDD - #1721

Open
shirinpanahian wants to merge 6 commits into
CodeYourFuture:mainfrom
shirinpanahian:coursework/sprint-3-practice-tdd
Open

London | 26-ITP-Sep | Shirin Panahian | Sprint 2 | Practice TDD#1721
shirinpanahian wants to merge 6 commits into
CodeYourFuture:mainfrom
shirinpanahian:coursework/sprint-3-practice-tdd

Conversation

@shirinpanahian

@shirinpanahian shirinpanahian commented Oct 16, 2026

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Task code

CYF-1060

Changelist

Completed the three exercises in Practice TDD.

@shirinpanahian shirinpanahian added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 16, 2026
@hackertainment hackertainment added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 22, 2026
hackertainment
hackertainment reviewed Oct 22, 2026
View reviewed changes

@hackertainment hackertainment left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your coursework. Please fix the ordinal number program and the test cases.

Comment thread practice-tdd/get-ordinal-number.js

@hackertainment hackertainment Oct 22, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This program seems not quite right to me. Why input cannot be ended with 11 or 22 or 33 ? They should all be valid. Please check the definition of ordinal number carefully, and fix the program (with test cases). Thank you.

@shirinpanahian shirinpanahian Oct 22, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback! I've corrected the ordinal number tests to handle the special cases ending in 11, 12, and 13, and added test cases for numbers ending in 22 and 33 to ensure they return nd and rd respectively.

@hackertainment hackertainment Oct 23, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, and it looks better now.

@hackertainment hackertainment added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Oct 22, 2026
@hackertainment hackertainment mentioned this pull request Oct 22, 2026
Open
@shirinpanahian shirinpanahian added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 22, 2026
@hackertainment

hackertainment commented Oct 23, 2026

Copy link
Copy Markdown

Congratulation, you have completed this PR successfully.

@hackertainment hackertainment added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@hackertainment hackertainment hackertainment left review comments
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shirinpanahian @hackertainment